-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create new team #1925
feat: Create new team #1925
Conversation
@ksushant6566 is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions for pull request titles! 馃檹 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ksushant6566 thank you very much for taking up this feature! 馃挭 Works great! 馃殌馃敟
There is only one issue I've noticed:
- The /create-first-team is also accessible for users who are not signed in. Please add a session check to the page. You can see the
onboarding
page for reference.
Also for this it would be great if thepage.tsx
would be a server component (instead of a client component) and rather render a client-only child component.
Can you please make the changes for this? 馃
After this we are ready to merge the feature 馃挭
Sure, i'll make these changes :) |
Hey @mattinannt , just pushed the requested changes:
Also I noticed an issue in the loom: https://www.loom.com/share/e6f8412761eb41c2a81bd9831a208ab1?sid=0ee2d535-bca4-4d26-9ab5-1daabb6030d5 FIX:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ksushant6566 thanks a lot for the changes 馃挭 Looks great now! Ready to merge this 馃槉馃敟
Happy to help :) |
What does this PR do?
/create-first-team
if they have no teamFixes #1816
Loom Video: https://www.loom.com/share/843147c04785426eb667b5a2c664bc00?sid=e1a9b526-fa43-4536-b446-4c6d10bd9784
How should this be tested?
create-first-team
environments/environmentId/surveys
Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated