Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (docs) introducing in-app surveys section #1942

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

  • Introduces a new In-App Surveys section in the docs (like the Link Surveys)
  • Rewrites the Actions section to an Actions Page inside the in app surveys
  • Rewrites the Attributes section to an Attributes Page inside the in app surveys
  • Writes redirects in the next config for the above

image

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 1:06pm
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 1:06pm

Copy link
Contributor

github-actions bot commented Jan 23, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala Thanks for the PR :-) 💪🔥
As I now see the docs I think we should move the entries from the Getting started section also to in-App Surveys as they are also in-app survey specific.
Also I think we should keep Identify Users ( https://formbricks.com/docs/attributes/identify-users ) (below Troubleshooting) and explain the basics of Identified users vs. unidentified users (including setting userId and logout). The extended explanation with how to set attributes in the code should still be in Attributes.

@ShubhamPalriwala
Copy link
Contributor Author

Hey, thanks for the feedback! Just made the changes, please take a look now 🤞🏼

The new In-App Surveys Section along with the new User Identification Page:
image
image
image

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala thank you, looks great! 😊🔥
I only updated the Identify user page a bit in terms of wording and information that might be useful to the user to make a decision what to use.

@mattinannt mattinannt added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 1945b6d Jan 24, 2024
12 checks passed
@mattinannt mattinannt deleted the shubham/for-1701-add-in-app-surveys-section-to-docs branch January 24, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants