-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (docs) introducing in-app surveys section #1942
feat: (docs) introducing in-app surveys section #1942
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Thank you for following the naming conventions for pull request titles! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShubhamPalriwala Thanks for the PR :-) 💪🔥
As I now see the docs I think we should move the entries from the Getting started
section also to in-App Surveys
as they are also in-app survey specific.
Also I think we should keep Identify Users
( https://formbricks.com/docs/attributes/identify-users ) (below Troubleshooting
) and explain the basics of Identified users vs. unidentified users (including setting userId and logout). The extended explanation with how to set attributes in the code should still be in Attributes
.
…shubham/for-1701-add-in-app-surveys-section-to-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShubhamPalriwala thank you, looks great! 😊🔥
I only updated the Identify user
page a bit in terms of wording and information that might be useful to the user to make a decision what to use.
What does this PR do?
Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated