fix: e2e flakyness

[pandeymangg]

What does this PR do?

Fixes flaky e2e tests, implements strategies like waiting for response and so on

Fixes # (issue)

How should this be tested?

• Run e2e tests

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues
• First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)		Jan 25, 2024 9:26am
formbricks-com	⬜️ Ignored (Inspect)		Jan 25, 2024 9:26am

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[review-agent-prime]

apps/web/playwright/survey.spec.ts

While the current implementation is good, it can be further improved by using a variable for the file content instead of hardcoding it. This will make it easier to change the file content for different tests.
Create Issue
See the diff
Checkout the fix

    const fileContent = "this is test";
    await page.locator("input[type=file]").setInputFiles({
      name: "file.txt",
      mimeType: "text/plain",
      buffer: Buffer.from(fileContent),
    });

git fetch origin && git checkout -b ReviewBot/The-c-o6xor2m origin/ReviewBot/The-c-o6xor2m

[review-agent-prime]

The hardcoded file content in the file upload test has been replaced with a variable. This allows for easier modification of the file content for different tests.

Suggested change

	await page.locator("input[type=file]").setInputFiles({
	name: "file.txt",
	mimeType: "text/plain",
	buffer: Buffer.from("this is test"),
	});
	const fileContent = 'this is test';
	await page.locator('input[type=file]').setInputFiles({
	name: 'file.txt',
	mimeType: 'text/plain',
	buffer: Buffer.from(fileContent),
	});