Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tweak sharing results UX #1964

Merged
merged 1 commit into from
Jan 26, 2024
Merged

chore: tweak sharing results UX #1964

merged 1 commit into from
Jan 26, 2024

Conversation

jobenjada
Copy link
Member

the dropdown is now responsive dependent on the published state of the results

Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Jan 26, 2024 9:04am
formbricks-com ⬜️ Ignored (Inspect) Jan 26, 2024 9:04am

Copy link
Contributor

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/components/ResultsShareButton.tsx

It would be beneficial to provide more specific error messages to the user when the copy to clipboard operation fails. This can be achieved by using the error object returned by the catch block. This will help the user understand the exact issue and possibly how to resolve it.
Create Issue
See the diff
Checkout the fix

    .catch((err) => {
      console.error("Failed to copy: ", err);
      toast.error(`Failed to copy link to results to clipboard. Error: ${err.message}`);
    });
git fetch origin && git checkout -b ReviewBot/Impro-lcpnncm origin/ReviewBot/Impro-lcpnncm

@jobenjada jobenjada added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 4dfe1d9 Jan 26, 2024
13 of 15 checks passed
@jobenjada jobenjada deleted the tweak-share-results branch January 26, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant