Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Aptabase to OSS friends #1969

Merged
merged 2 commits into from
Jan 26, 2024
Merged

docs: add Aptabase to OSS friends #1969

merged 2 commits into from
Jan 26, 2024

Conversation

goenning
Copy link
Contributor

What does this PR do?

Adding Aptabase to OSS Friends ❤️

Page: https://aptabase.com/oss-friends
GH: https://github.com/aptabase/aptabase

Thanks

Copy link

vercel bot commented Jan 26, 2024

@goenning is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Jan 26, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

apps/formbricks-com/pages/api/oss-friends/index.ts

Instead of hardcoding the data directly in the function, it would be more efficient and readable to store it in a separate JSON file. This way, the function will be cleaner and the data can be managed separately, which is especially useful if the data grows or needs to be updated frequently.
Create Issue
See the diff
Checkout the fix

    import data from './data.json';

    export default async function handle(req: NextApiRequest, res: NextApiResponse) {
      // GET
      if (req.method === "GET") {
        return res.status(200).json({ data });
      }

      // Unknown HTTP Method
      else {
        throw new Error(`The HTTP ${req.method} method is not supported by this route.`);
      }
    }
git fetch origin && git checkout -b ReviewBot/Impro-o3p9pep origin/ReviewBot/Impro-o3p9pep

@jobenjada jobenjada added this pull request to the merge queue Jan 26, 2024
Merged via the queue into formbricks:main with commit 1fb165e Jan 26, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants