Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Randomizer for in-app surveys #1972

Merged
merged 6 commits into from
Jan 29, 2024
Merged

feat: Randomizer for in-app surveys #1972

merged 6 commits into from
Jan 29, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Adds randomizer for in-app surveys
Tweaks in survey trigger card

Screenshot 2024-01-29 at 11 46 23 AM

Fixes 1798 #1960

How should this be tested?

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 0:32am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 0:32am

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thanks for the feature :-) I would like to change a few smaller things before we can merge :-)

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thanks for making the changes; looks great! 😊💪

@mattinannt mattinannt added this pull request to the merge queue Jan 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2024
@mattinannt mattinannt added this pull request to the merge queue Jan 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2024
@mattinannt mattinannt added this pull request to the merge queue Jan 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2024
@mattinannt mattinannt added this pull request to the merge queue Jan 29, 2024
Merged via the queue into main with commit 698da4c Jan 29, 2024
13 checks passed
@mattinannt mattinannt deleted the randomizer branch January 29, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants