Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add debug mode via url parameter #2039

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

jonas-hoebenreich
Copy link
Contributor

What does this PR do?

When debugging in-app surveys & triggers it would be helpful to have an option to enable the debug mode on the fly by adding a parameter to the URL.
You can now add ?formbricksDebug=1 to the URL to enable debugging

Fixes #2016

How should this be tested?

  • add pixel to page without debug mode enabled, add ?formbricksDebug=1 to the url

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Feb 8, 2024

@jonas-hoebenreich is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the enhancement New feature or request label Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonas-hoebenreich thanks a lot for the PR 😊💪 Very cool that you added docs, too 🤩
Only one comment/question before we move on with the merge:

packages/js/src/lib/initialize.ts Outdated Show resolved Hide resolved
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonas-hoebenreich thanks a lot for making the changes 😊💪🚀

@mattinannt mattinannt added this pull request to the merge queue Feb 12, 2024
Merged via the queue into formbricks:main with commit 531facd Feb 12, 2024
8 of 10 checks passed
@jonas-hoebenreich jonas-hoebenreich deleted the debug-mode branch March 16, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 discussion enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] add debug mode to in-app pixel
2 participants