Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: weekly template #2041

Merged
merged 1 commit into from
Feb 9, 2024
Merged

fix: weekly template #2041

merged 1 commit into from
Feb 9, 2024

Conversation

Dhruwang
Copy link
Contributor

@Dhruwang Dhruwang commented Feb 8, 2024

What does this PR do?

Fixes 1806
1864

How should this be tested?

Screenshot 2024-02-08 at 11 26 33

This issue occurs when there are surveys for an account and email is viewed on smaller devices

image

This issue occurs for paused surveys

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Feb 8, 2024 0:31am
formbricks-com ⬜️ Ignored (Inspect) Feb 8, 2024 0:31am

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@jobenjada
Copy link
Member

@ShubhamPalriwala pls review this and merge if looks good :)

Copy link
Member

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it locally and looks great! Thanks @Dhruwang 💪🏼

@ShubhamPalriwala ShubhamPalriwala added this pull request to the merge queue Feb 9, 2024
Merged via the queue into main with commit c372108 Feb 9, 2024
15 checks passed
@ShubhamPalriwala ShubhamPalriwala deleted the weekly-ui-issue branch February 9, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants