fix: team issues

[Dhruwang]

What does this PR do?

Fixes #2044 #2042

How should this be tested?

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)	Visit Preview		Feb 12, 2024 9:49am
formbricks-com	⬜️ Ignored (Inspect)	Visit Preview		Feb 12, 2024 9:49am

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[review-agent-prime]

packages/lib/user/service.ts

Instead of accessing the properties of currentUserMembership multiple times, you can use destructuring to extract the properties once and use them. This will make the code more readable.
Create Issue
See the diff
Checkout the fix

    const { role, teamId, team: { memberships: teamMemberships } } = currentUserMembership;

git fetch origin && git checkout -b ReviewBot/Impro-q38x38v origin/ReviewBot/Impro-q38x38v

[mattinannt]

@Dhruwang thanks for fixing the two issues 😊🚀
I changed the membership revalidation in a way that I explicitly delete the membership using the service (which also revalidates the cache).
Your code had the issue that it revalidated the cache before removing the user (together with the membership) from the database which could still lead to an inconsistent cache.