Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multi select scroll issue #2053

Merged
merged 1 commit into from
Feb 12, 2024
Merged

fix: multi select scroll issue #2053

merged 1 commit into from
Feb 12, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Fixes 1816

How should this be tested?

Test with consecutive scrollable single select/ multi select questions

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Feb 12, 2024 7:33am
formbricks-com ⬜️ Ignored (Inspect) Feb 12, 2024 7:33am

Copy link
Contributor

Thank you for following the naming conventions for pull request titles! 🙏

@jobenjada jobenjada self-assigned this Feb 12, 2024
@jobenjada jobenjada added this pull request to the merge queue Feb 12, 2024
@jobenjada
Copy link
Member

looks good, thanks @Dhruwang :)

Merged via the queue into main with commit 7c0a9be Feb 12, 2024
15 checks passed
@jobenjada jobenjada deleted the scroll-value-issue branch February 12, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants