Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: redirect for deletion survey #2054

Merged
merged 4 commits into from
Feb 12, 2024
Merged

chore: redirect for deletion survey #2054

merged 4 commits into from
Feb 12, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

If on formbricks cloud, users will be redirected to deletion survey on account deletion

Fixes 1743

How should this be tested?

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 10:48am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 10:48am

Copy link
Contributor

github-actions bot commented Feb 12, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thank you very much for adding the deletion survey 😊🚀
I refactored the code a bit to be able to test this properly on localhost and to make the redirect logic a bit easier to read 😊

@mattinannt mattinannt added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit 77e2472 Feb 12, 2024
13 checks passed
@mattinannt mattinannt deleted the delete-account-survey branch February 12, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants