Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache revalidation on createResponse and docs #2057

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

If you create a response and try to retrieve all the response via environmentId using management API, new response wont be present in it, because of cache not being revalidated

Fixes # (issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 10:30am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 10:30am

Copy link
Contributor

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

packages/lib/response/service.ts

Consider fetching the person data in the same database call when creating the response. This can reduce the number of database calls and improve the performance of the code.
Create Issue
See the diff
Checkout the fix

    const responsePrisma = await prisma.response.create({
      data: {
        survey: {
          connect: {
            id: surveyId,
          },
        },
        finished: finished,
        data: data,
        ...(userId && {
          person: {
            connectOrCreate: {
              create: { userId: userId, environmentId: environmentId },
              where: { userId_environmentId: { userId: userId, environmentId: environmentId } }
            },
          },
        }),
        ...(meta && ({ meta } as Prisma.JsonObject)),
        singleUseId,
      },
      select: responseSelection,
    });
git fetch origin && git checkout -b ReviewBot/Impro-1042dq2 origin/ReviewBot/Impro-1042dq2

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thank you for the fix and the docs update 😊🚀💪

@mattinannt mattinannt added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit 336480a Feb 12, 2024
15 checks passed
@mattinannt mattinannt deleted the hidden-field-in-response branch February 12, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants