Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect for nested windows #2074

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix: redirect for nested windows #2074

merged 1 commit into from
Feb 14, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Right now redirect does not work for nested windows (iframe) so replaced window.location.replace with window.top.location

Fixes # (issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 10:55am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 10:55am

Copy link
Contributor

Thank you for following the naming conventions for pull request titles! 🙏

@Dhruwang Dhruwang mentioned this pull request Feb 14, 2024
11 tasks
@mattinannt mattinannt added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit 82207d8 Feb 14, 2024
15 checks passed
@mattinannt mattinannt deleted the redirect-logic branch February 14, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants