Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link-surveys: hidden fields page #2082

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

ShubhamPalriwala
Copy link
Member

What does this PR do?

image
image

Fixes # (issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 11:24am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 11:24am

Copy link
Contributor

github-actions bot commented Feb 15, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala thank you for adding the docs page 😊💪
I like that it's short and with good examples. I think we should also add that the user must enable hidden fields in the survey editor and add the id of the field that should be available as a hidden field.
Also some screenshots for this process editor and the final response in the response card would be great 😊

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala thanks a lot for making the changes 😊
I'm very happy to see the screenshots with the correct font 😅🚀🔥

@mattinannt mattinannt added this pull request to the merge queue Feb 19, 2024
Merged via the queue into main with commit 606ca4e Feb 19, 2024
13 checks passed
@mattinannt mattinannt deleted the shubham/for-1873-add-docs-for-hidden-fields branch February 19, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants