fix: dont interrupt response on display updation failure

[ShubhamPalriwala]

What does this PR do?

Currently the Response Creation on Surveys block if the Display Update API throws an error even if the Response API is working fine!

This PR fixes it by ignoring the display updation if it fails!

How should this be tested?

• Change the API Host of the Display API & try submitting a response

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)	Visit Preview		Feb 22, 2024 2:37pm
formbricks-com	⬜️ Ignored (Inspect)	Visit Preview		Feb 22, 2024 2:37pm

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[review-agent-prime]

packages/lib/responseQueue.ts

Instead of using console.log for error logging, it would be better to use a dedicated logging library that provides more flexibility and control over log levels, formats, and destinations. This will improve the readability and maintainability of your code.
Create Issue
See the diff
Checkout the fix

    import { Logger } from 'some-logging-library';

    const logger = new Logger();

    // ...

    try {
      await this.api.client.display.update(this.surveyState.displayId, {
        responseId: response.data.id,
      });
    } catch (error) {
      logger.error("Failed to update display, proceeding with the response.", error);
    }

git fetch origin && git checkout -b ReviewBot/Impro-gzwe8cm origin/ReviewBot/Impro-gzwe8cm

It's a good practice to not expose the entire error object in the logs, especially in production, as it may contain sensitive information. Instead, log only the necessary details such as the error message.
Create Issue
See the diff
Checkout the fix

    try {
      await this.api.client.display.update(this.surveyState.displayId, {
        responseId: response.data.id,
      });
    } catch (error) {
      logger.error(`Failed to update display, proceeding with the response. Error: ${error.message}`);
    }

git fetch origin && git checkout -b ReviewBot/Impro-tqgfnpz origin/ReviewBot/Impro-tqgfnpz

[review-agent-prime]

The error object is being logged entirely which may expose sensitive information. The fix involves logging only the error message.

Suggested change

	await this.api.client.display.update(this.surveyState.displayId, {
	responseId: response.data.id,
	});
	} catch (error) {
	console.log("Failed to update display, proceeding with the response.", error);
	}
	```typescript
	try {
	await this.api.client.display.update(this.surveyState.displayId, {
	responseId: response.data.id,
	});
	} catch (error) {
	console.log(`Failed to update display, proceeding with the response. Error: ${error.message}`);
	}
	```

[mattinannt]

@ShubhamPalriwala thanks for the PR 😊💪