Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dockerfile to use turbo prune #2121

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

mattinannt
Copy link
Member

What does this PR do?

update dockerfile to use turbo prune and same prisma version throughout the process

Copy link

vercel bot commented Feb 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Feb 24, 2024 3:32pm
formbricks-com ⬜️ Ignored (Inspect) Feb 24, 2024 3:32pm

Copy link
Contributor

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

docker-compose.yml

It's not a good practice to hardcode sensitive information such as database URLs, secrets, encryption keys, SMTP details, etc. directly in the docker-compose file. Instead, these should be stored in environment variables or secure vaults and referenced in the docker-compose file.
Create Issue
See the diff
Checkout the fix

    x-database-url: &database_url ${DATABASE_URL}
    x-nextauth-secret: &nextauth_secret ${NEXTAUTH_SECRET}
    x-nextauth-url: &nextauth_url ${NEXTAUTH_URL}
    x-encryption-key: &encryption_key ${ENCRYPTION_KEY}
    x-mail-from: &mail_from ${MAIL_FROM}
    x-smtp-host: &smtp_host ${SMTP_HOST}
    x-smtp-port: &smtp_port ${SMTP_PORT}
    x-smtp-secure-enabled: &smtp_secure_enabled ${SMTP_SECURE_ENABLED}
    x-smtp-user: &smtp_user ${SMTP_USER}
    x-sentry-ignore-api-resolution-error: &sentry_ignore_api_resolution_error ${SENTRY_IGNORE_API_RESOLUTION_ERROR}
    x-next-public-sentry-dsn: &next_public_sentry_dsn ${NEXT_PUBLIC_SENTRY_DSN}
    x-cron-secret: &cron_secret ${CRON_SECRET}
git fetch origin && git checkout -b ReviewBot/Impro-x21xzc3 origin/ReviewBot/Impro-x21xzc3

It's recommended to use a secure version of PostgreSQL. The 'postgres:15-alpine' image is not secure and can be vulnerable to attacks. Consider using a secure and updated version of PostgreSQL.
Create Issue
See the diff
Checkout the fix

    services:
      postgres:
        image: postgres:latest
git fetch origin && git checkout -b ReviewBot/Impro-t4bw7fi origin/ReviewBot/Impro-t4bw7fi

@mattinannt mattinannt added this pull request to the merge queue Feb 24, 2024
Merged via the queue into main with commit 78ed91b Feb 24, 2024
15 checks passed
@mattinannt mattinannt deleted the feature/update-dockerfile branch February 24, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant