Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom S3 endpoint to use third party storage services #2133

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

sebiweise
Copy link
Contributor

What does this PR do?

I´ve added the available S3 environment vars to .env.example.
Also added the ability to define a custom S3 endpoint to use Third Party S3 compatible storage services like StorJ.

How should this be tested?

Register for StorJ or another S3 storage provider
Define all environment vars:

Checklist

  • Upload profile picture
  • Upload picture question image
  • Upload files in file upload question

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Feb 27, 2024

@sebiweise is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Feb 27, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@mattinannt
Copy link
Member

@sebiweise I would like to make changes to the PR but unfortunately I'm not able to push them. Did you allow maintainers to make changes?

@sebiweise
Copy link
Contributor Author

@sebiweise I would like to make changes to the PR but unfortunately I'm not able to push them. Did you allow maintainers to make changes?

I don´t really know how to do this, can you tell what I have to change so that you can push changes?

@sebiweise sebiweise reopened this Feb 27, 2024
@mattinannt
Copy link
Member

mattinannt commented Feb 27, 2024

Screenshot 2024-02-27 at 09 53 00 When creating the pull request you can select this option. I'm not sure if you can also change this setting afterwards. If it's enabled we should be able to see this in the info-bar on the right:

image


Update: you might be able to just check it:
Screenshot 2024-02-27 at 09 54 48

@sebiweise sebiweise closed this Feb 27, 2024
@sebiweise sebiweise reopened this Feb 27, 2024
@sebiweise
Copy link
Contributor Author

sebiweise commented Feb 27, 2024

Unfortunately I don´t have this options.
I tried to recreate the PR but even then I don´t have the option to enable maintainer edit.

@sebiweise
Copy link
Contributor Author

@sebiweise
Copy link
Contributor Author

Fixed it, you should be able to edit now.

@mattinannt mattinannt added this pull request to the merge queue Feb 27, 2024
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebiweise Nice, it's working now, thank you ☺️🚀💪
I changed a few smaller things and merge it now 🔥

Thanks a lot for your contribution 😊

Merged via the queue into formbricks:main with commit 5acdf01 Feb 27, 2024
9 of 11 checks passed
@sebiweise sebiweise deleted the feature/custom_s3_endpoint branch February 27, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants