-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: preview bugs #2134
fix: preview bugs #2134
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Thank you for following the naming conventions for pull request titles! 🙏 |
apps/web/app/(app)/environments/[environmentId]/surveys/components/Modal.tsxConsider using a switch statement instead of multiple if-else statements to improve the readability of the code. // Use a switch statement
let placementClass = "";
switch (placement) {
case "bottomLeft":
placementClass = "bottom left";
break;
case "bottomRight":
placementClass = "bottom right";
break;
case "topLeft":
placementClass = "top left";
break;
case "topRight":
placementClass = "top right";
break;
}
apps/web/app/(app)/environments/[environmentId]/surveys/components/PreviewSurvey.tsxThe variable name 'shrink' is not very descriptive and does not clearly convey its purpose. A more descriptive name like 'isFullScreenShrink' would make the code easier to understand. const [isFullScreenShrink, setIsFullScreenShrink] = useState(false);
packages/surveys/src/components/general/Smileys.tsxConsider adding a CSS class to the SVG elements and use CSS to control their size. This will make the SVGs more flexible and easier to control from a central location. <svg viewBox="0 0 72 72" xmlns="http://www.w3.org/2000/svg" className="svg-icon">
```
And in your CSS file:
```css
.svg-icon {
width: 48px;
height: 48px;
}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruwang thanks a lot for the fixes 😊💪🚀
@Dhruwang It seems like there's an e2e error. Can you please take a look? 😊 |
…bricks into smiley-issue-fix
What does this PR do?
Fixes 1937
Fixes below mentioned issues
Slide up animation not working
Screen.Recording.2024-02-27.at.4.46.04.PM.mov
Broken Rating question (scale: star)
Double scroll bar for multi-choice question, file upload, picture select and cal question
Screen.Recording.2024-02-27.at.4.48.33.PM.mov
Broken rating question (scale:smiley)
Missing min width
How should this be tested?
Survey editor preview
Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated