Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cta button issue on thank you card #2148

Merged
merged 4 commits into from
Mar 1, 2024
Merged

fix: Cta button issue on thank you card #2148

merged 4 commits into from
Mar 1, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Fixes 1944

How should this be tested?

There are four possibilities

Thank you card on link survey (we check for isResponseSendingFinished ✅)
On in app survey (we check for isResponseSendingFinished ✅)

Here CTA button will be always shown if enabled
In Survey Editor (we dont check here ❌)
In link survey preview (we dont check here ❌)

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2024 9:32am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2024 9:32am

Copy link
Contributor

github-actions bot commented Feb 28, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@jobenjada jobenjada enabled auto-merge March 1, 2024 09:32
@jobenjada jobenjada added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit cdd93ee Mar 1, 2024
12 of 13 checks passed
@jobenjada jobenjada deleted the CTA-card-issue branch March 1, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants