feat: Move Response Summary Server-side #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gupta-piyush19 is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions for pull request titles! 🙏 |
…piyush/for-1911-concept-move-response-summary-server-side
…piyush/for-1911-concept-move-response-summary-server-side
…piyush/for-1911-concept-move-response-summary-server-side
mattinannt
reviewed
Mar 6, 2024
packages/lib/response/service.ts
Outdated
|
|
||
| return { meta, dropoff, summary: questionWiseSummary }; | ||
| }, | ||
| [`getSurveyMeta-${surveyId}-${JSON.stringify(filterCriteria)}`], |
There was a problem hiding this comment.
please rename getSurveyMeta -> getSurveySummary (name of the function)
packages/lib/storage/utils.ts
Outdated
| @@ -1,5 +1,7 @@ | |||
| export const getOriginalFileNameFromUrl = (fileURL: string) => { | |||
| try { | |||
| if (!fileURL) return ""; | |||
There was a problem hiding this comment.
when does this happen? might it be better to throw an error here to signal that something went wrong?
There was a problem hiding this comment.
I had a few responses with empty filenames, seems like some polluted data. I am unable to reproduce the issue for which I added this check. removing it for now.
…piyush/for-1911-concept-move-response-summary-server-side
…de' of github.com:gupta-piyush19/formbricks into piyush/for-1911-concept-move-response-summary-server-side
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move Response Summary Server-side
fixes: https://linear.app/formbricks/issue/FOR-1911/[concept]-move-response-summary-server-side
How should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated