fix: multiple surveys might be showing at the same time

[mattinannt]

What does this PR do?

fix: multiple surveys might be showing at the same time

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)	Visit Preview		Mar 4, 2024 11:11am
formbricks-com	⬜️ Ignored (Inspect)	Visit Preview		Mar 4, 2024 11:11am

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[review-agent-prime]

packages/js/src/lib/widget.ts

The renderWidget function is quite long and complex. It would be beneficial to break it down into smaller, more manageable functions. This would make the code easier to read and maintain.
Create Issue
See the diff
Checkout the fix

    const setupProductOverwrites = (product, productOverwrites) => {
      const brandColor = productOverwrites.brandColor ?? product.brandColor;
      const highlightBorderColor = productOverwrites.highlightBorderColor ?? product.highlightBorderColor;
      const clickOutside = productOverwrites.clickOutsideClose ?? product.clickOutsideClose;
      const darkOverlay = productOverwrites.darkOverlay ?? product.darkOverlay;
      const placement = productOverwrites.placement ?? product.placement;
      const isBrandingEnabled = product.inAppSurveyBranding;
      
      return {brandColor, highlightBorderColor, clickOutside, darkOverlay, placement, isBrandingEnabled};
    }
    
    const handleOnDisplay = async (survey, surveyState, responseQueue) => {
      // existing onDisplay code...
    }
    
    const handleOnResponse = (responseUpdate, surveyState, responseQueue) => {
      // existing onResponse code...
    }
    
    const handleOnFileUpload = async (file, params) => {
      // existing onFileUpload code...
    }
    
    // In the main function
    const productOverwrites = setupProductOverwrites(product, survey.productOverwrites ?? {});
    handleOnDisplay(survey, surveyState, responseQueue);
    handleOnResponse(responseUpdate, surveyState, responseQueue);
    handleOnFileUpload(file, params);

git fetch origin && git checkout -b ReviewBot/Impro-wdli5d2 origin/ReviewBot/Impro-wdli5d2

The config.get() function is called multiple times within the renderWidget function. This could potentially slow down the execution of the function, especially if the config.get() function is expensive in terms of computational resources. It would be more efficient to call this function once at the beginning of the renderWidget function and store the result in a variable, which can then be used throughout the function.
Create Issue
See the diff
Checkout the fix

    const configData = config.get();
    const product = configData.state.product;
    const apiHost = configData.apiHost;
    const environmentId = configData.environmentId;
    const userId = configData.userId;
    // Use these variables instead of calling config.get() multiple times

git fetch origin && git checkout -b ReviewBot/Impro-3xi3mbe origin/ReviewBot/Impro-3xi3mbe