Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Call to Action question bug #2184

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix: Call to Action question bug #2184

merged 1 commit into from
Mar 5, 2024

Conversation

gupta-piyush19
Copy link
Contributor

@gupta-piyush19 gupta-piyush19 commented Mar 5, 2024 •
edited

What does this PR do?

Call to Action question bug
removes the blank line in case of empty description.

Fixes: https://linear.app/formbricks/issue/FOR-1957/call-to-action-question-bug

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel Vercel
Copy link

vercel bot commented Mar 5, 2024

@gupta-piyush19 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024 •
edited

Thank you for following the naming conventions for pull request titles! 🙏

mattinannt
mattinannt approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gupta-piyush19 thank you for the fix :-)

@mattinannt mattinannt added this pull request to the merge queue Mar 5, 2024
Merged via the queue into formbricks:main with commit 73a25a4 Mar 5, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattinannt mattinannt mattinannt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gupta-piyush19 @mattinannt