Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove s3 check from health check for now #2194

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Conversation

mattinannt
Copy link
Member

What does this PR do?

chore: remove s3 check from health check for now

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 8:44am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 8:44am

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

apps/web/app/health/page.tsx

Instead of commenting out the S3 connection check function, consider using a feature toggle or environment variable to control its execution. This would make the code more flexible and maintainable.
Create Issue
See the diff
Checkout the fix

    const ENABLE_S3_CHECK = process.env.ENABLE_S3_CHECK || false;

    const checkS3Connection = async () => {
      if (!ENABLE_S3_CHECK) {
        return;
      }
      // rest of the function...
    };

    export default async function HealthPage() {
      await checkDatabaseConnection();
      if (ENABLE_S3_CHECK) {
        await checkS3Connection();
      }
      // rest of the function...
    }
git fetch origin && git checkout -b ReviewBot/The-S-bb2hy5g origin/ReviewBot/The-S-bb2hy5g

@mattinannt mattinannt added this pull request to the merge queue Mar 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2024
@mattinannt mattinannt added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit 1df1419 Mar 6, 2024
12 of 14 checks passed
@mattinannt mattinannt deleted the feature/fix-health branch March 6, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant