Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Smiley Rating Question on iPhone / WebKit #2195

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix: Smiley Rating Question on iPhone / WebKit #2195

merged 1 commit into from
Mar 7, 2024

Conversation

gupta-piyush19
Copy link
Contributor

What does this PR do?

fixes smiley Rating Question on iPhone / WebKit

Fixes # (issue)
https://linear.app/formbricks/issue/FOR-1981/fix-smiley-rating-question-on-iphone-webkit

How should this be tested?

  • Can be tested on iphone, for any rating question with selector as smiley or star.
  • can be tested on iPhone simulator on mac's Xcode

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel Vercel
Copy link

vercel bot commented Mar 6, 2024

@gupta-piyush19 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@jobenjada jobenjada added this pull request to the merge queue Mar 7, 2024
Merged via the queue into formbricks:main with commit 57d117e Mar 7, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🙋‍♀️ to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gupta-piyush19 @mattinannt @jobenjada