feat: Add Server-side pagination to Surveys List #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gupta-piyush19 is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions for pull request titles! 🙏 |
…piyush/for-1979-add-server-side-pagination-to-surveys-list
…piyush/for-1979-add-server-side-pagination-to-surveys-list
mattinannt
reviewed
Mar 13, 2024
packages/lib/survey/service.ts
Outdated
| @@ -320,6 +330,37 @@ export const getSurveys = async (environmentId: string, page?: number): Promise< | |||
| return surveys.map((survey) => formatDateFields(survey, ZSurvey)); | |||
| }; | |||
|
|
|||
| export const getSurveyCountByEnvironmentId = async (environmentId: string): Promise<number> => { | |||
There was a problem hiding this comment.
We have an implicit convention where you don't need the ByEnvironmentId (or similar) if it's the default parent of the object (so that we get simple getSurveys or other functions). So in this case ByEnvironmentId is not needed.
…piyush/for-1979-add-server-side-pagination-to-surveys-list
…piyush/for-1979-add-server-side-pagination-to-surveys-list
mattinannt
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
@gupta-piyush19 thanks for making the changes :-) Works great! 👍💪🚀
|
@gupta-piyush19 Can you please check on the failing tests? |
…piyush/for-1979-add-server-side-pagination-to-surveys-list
…ist' of https://github.com/gupta-piyush19/formbricks into piyush/for-1979-add-server-side-pagination-to-surveys-list
…piyush/for-1979-add-server-side-pagination-to-surveys-list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Server-side pagination to Surveys List
Fixes https://linear.app/formbricks/issue/FOR-1979/add-server-side-pagination-to-surveys-list
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated