Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add button to link editor #2200

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix: Add button to link editor #2200

merged 2 commits into from
Mar 7, 2024

Conversation

Dhruwang
Copy link
Contributor

@Dhruwang Dhruwang commented Mar 7, 2024

What does this PR do?

Adds Add button link editor
Also fixes an issue where editor does not close on link submission

Fixes 1946

How should this be tested?

Screen.Recording.2024-03-07.at.5.32.49.PM.mov

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2024 2:33pm
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2024 2:33pm

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

packages/ui/Editor/components/ToolbarPlugin.tsx

The useEffect hook that sets the edit mode to true on component mount might cause unnecessary re-renders. This can be avoided by setting the initial state of isEditMode to true.
Create Issue
See the diff
Checkout the fix

    const [isEditMode, setEditMode] = useState(true);
git fetch origin && git checkout -b ReviewBot/Impro-pdb0k9u origin/ReviewBot/Impro-pdb0k9u

@jobenjada jobenjada added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit f3f93fa Mar 7, 2024
12 of 14 checks passed
@jobenjada jobenjada deleted the add-button-to-input-field branch March 7, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants