Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: survey background image upload issue #2222

Merged
merged 8 commits into from
Mar 13, 2024
Merged

fix: survey background image upload issue #2222

merged 8 commits into from
Mar 13, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Fixes 2009

Survey background Image upload was breaking locally, irrespective of file size. We recently made a change in getuploadSignedUrl where, for self hosters we send relative path of file instead url, due to which it worked fine on cloud but was misbehaving locally

Screenshot 2024-03-12 at 5 49 18 PM

Also fixes this warning here

Screenshot 2024-03-12 at 5 40 37 PM

Also adds a error toast to indicate if file size exceeds the given limit

Screenshot 2024-03-12 at 5 38 21 PM

How should this be tested?

Try to set background image for a survey

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 8:22am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 8:22am

Copy link
Contributor

github-actions bot commented Mar 12, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@mattinannt mattinannt added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit 65a152e Mar 13, 2024
12 of 14 checks passed
@mattinannt mattinannt deleted the upload-issue branch March 13, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants