Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added image link #2228

Conversation

gupta-piyush19
Copy link
Contributor

What does this PR do?

added image link

Fixes
https://linear.app/formbricks/issue/FOR-1984/%5Bfeature%5D-increase-size-of-attached-images

link.mp4

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Mar 13, 2024

@gupta-piyush19 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Thank you for following the naming conventions for pull request titles! 🙏

…piyush/for-1984-feature-increase-size-of-attached-images
@jobenjada
Copy link
Member

Tweaked the UI a bit to make it take less real estate since it's a thaaaat important to draw as much attention as it did.

Wondering one thing:

  1. When I click expand on the picture select a new tab opens.
  2. When I click expand on the header image, it downloads the image 🤔

Please make sure that it always displays the image in a new tab.

image

Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@gupta-piyush19
Copy link
Contributor Author

Thanks, @jobenjada, for the UI changes.
For the image download issue, it's happening only because the image is not hosted on S3. I tried with the hosted image, and it always opens in the new tab.

hosted-image.mp4

@mattinannt mattinannt added this pull request to the merge queue Mar 14, 2024
Merged via the queue into formbricks:main with commit 1a28660 Mar 14, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants