feat: opentelemetry integration #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shubham/for-2023-self-host-signoz-for-trying-out-their-monitoring
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
apps/web/instrumentation.tsIt's a good practice to add error handling to the OpenTelemetry instrumentation setup. This will help in identifying any issues that might occur during the setup process and prevent the application from crashing due to unhandled exceptions. try {
startInstrumentationForNode(process.env.NEXT_PUBLIC_OPENTELEMETRY_LISTENER_URL);
} catch (error) {
console.error('Failed to start OpenTelemetry instrumentation:', error);
} |
![review-agent-prime[bot]](https://avatars.githubusercontent.com/in/404610?s=60&v=4){kind=small}
apps/web/instrumentation.ts
Outdated
Comment on lines
2
to
6
| if (process.env.NEXT_RUNTIME === "nodejs" && process.env.NEXT_PUBLIC_OPENTELEMETRY_LISTENER_URL) { | ||
| console.log("Configuring OpenTelemetry"); | ||
| const { startInstrumentationForNode } = await import("./instrumentation.node"); | ||
|
|
||
| startInstrumentationForNode(process.env.NEXT_PUBLIC_OPENTELEMETRY_LISTENER_URL); |
There was a problem hiding this comment.
Adding error handling to the OpenTelemetry instrumentation setup to prevent the application from crashing due to unhandled exceptions.
Suggested change
| if (process.env.NEXT_RUNTIME === "nodejs" && process.env.NEXT_PUBLIC_OPENTELEMETRY_LISTENER_URL) { | |
| console.log("Configuring OpenTelemetry"); | |
| const { startInstrumentationForNode } = await import("./instrumentation.node"); | |
| startInstrumentationForNode(process.env.NEXT_PUBLIC_OPENTELEMETRY_LISTENER_URL); | |
| if (process.env.NEXT_RUNTIME === "nodejs" && process.env.NEXT_PUBLIC_OPENTELEMETRY_LISTENER_URL) { | |
| console.log("Configuring OpenTelemetry"); | |
| const { startInstrumentationForNode } = await import("./instrumentation.node"); | |
| try { | |
| startInstrumentationForNode(process.env.NEXT_PUBLIC_OPENTELEMETRY_LISTENER_URL); | |
| } catch (error) { | |
| console.error('Failed to start OpenTelemetry instrumentation:', error); | |
| } | |
| } |
…-out-their-monitoring
…monitoring' of https://github.com/formbricks/formbricks into shubham/for-2023-self-host-signoz-for-trying-out-their-monitoring
mattinannt
deleted the
shubham/for-2023-self-host-signoz-for-trying-out-their-monitoring
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables exporting app metrics to any OpenTelemetry supported Client given the
NEXT_PUBLIC_OPENTELEMETRY_LISTENER_URLis passedHow should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated