chore: remove passing of build time env vars #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions for pull request titles! 🙏 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
mattinannt
reviewed
Mar 14, 2024
| @@ -78,9 +78,6 @@ jobs: | |||
| cache-from: type=gha | |||
| cache-to: type=gha,mode=max | |||
| build-args: | | |||
| NEXTAUTH_SECRET=${{ env.NEXTAUTH_SECRET }} | |||
| DATABASE_URL=${{ env.DATABASE_URL }} | |||
| ENCRYPTION_KEY=${{ env.ENCRYPTION_KEY }} | |||
There was a problem hiding this comment.
We also generate them in the workflow files. Can you please remove those commands, too :-)
mattinannt
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We recently hardcoded 3 of our required build time variables so that they only need to be passed at runtime where they overwrite these build time vars. This PR removes the passing to the github actions that use them currently
How should this be tested?
Ran the docker release action on my fork and it built the image successfully
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated