fix: Allow all URL-safe characters in hidden field Id/ questionId #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
mattinannt
reviewed
Mar 15, 2024
There was a problem hiding this comment.
since this is a library file, please use lowercase validation.ts for this file.
also this needs to be moved into the lib folder instead of the components folder :-)
|
@Dhruwang Looks good now 😊💪 Can you please solve the merge conflicts here? :-) |
mattinannt
approved these changes
Mar 21, 2024
…l-safe-characters-in-hidden-field
mattinannt
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
@Dhruwang thanks for fixing this 😊 In the meantime there is also one more user request for this feature so I will merge it now to make everyone happy 😊🚀
vidhikapadia2799
pushed a commit
to vidhikapadia2799/formbricks
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes 2010 #2332
Now underscore (_) and hyphen (-) is also allowed in hidden field Id / questionId
Also we were having separate logic for validating questionId and hidden field Id, added a common validation function for it
How should this be tested?
Use _ and - in hidden field Id and question Id
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated