fix: unable to save legacy surveys

[mattinannt]

What does this PR do?

fix: unable to save legacy surveys

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)			Mar 19, 2024 8:32am
formbricks-com	⬜️ Ignored (Inspect)	Visit Preview		Mar 19, 2024 8:32am

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[review-agent-prime]

packages/lib/utils/validate.ts

It would be more readable if the error message included the name of the schema that failed validation, rather than the entire schema object. This would make the error message more concise and easier to understand.
Create Issue
See the diff
Checkout the fix

    `Validation failed for ${JSON.stringify(value, null, 2)} and ${schema.name}: ${inputValidation.error.message}`

git fetch origin && git checkout -b ReviewBot/Impro-3p8ms9w origin/ReviewBot/Impro-3p8ms9w

packages/lib/constants.ts

Increasing the revalidation interval from 30 minutes to 3 hours might not be the best solution for all cases. If the data changes frequently, this could lead to outdated data being served to the users. Consider implementing a more dynamic revalidation strategy, such as using webhooks or event-driven updates, to ensure data freshness without unnecessary revalidations.
Create Issue
See the diff
Checkout the fix

    // Implement a dynamic revalidation strategy

git fetch origin && git checkout -b ReviewBot/Impro-xhzwtq5 origin/ReviewBot/Impro-xhzwtq5

[review-agent-prime]

The error message has been updated to include only the name of the schema that failed validation, making it more concise and easier to understand.

Suggested change

	`Validation failed for ${JSON.stringify(value, null, 2)} and ${JSON.stringify(schema)}: ${inputValidation.error.message}`
	console.error(
	`Validation failed for ${JSON.stringify(value, null, 2)} and ${schema.name}: ${inputValidation.error.message}`
	);

[review-agent-prime]

Implement a dynamic revalidation strategy to ensure data freshness without unnecessary revalidations.

Suggested change

	export const REVALIDATION_INTERVAL = 0; //TODO: find a good way to cache and revalidate data when it changes
	export const SERVICES_REVALIDATION_INTERVAL = 60 * 30; // 30 minutes
	export const SERVICES_REVALIDATION_INTERVAL = 60 * 60 * 3; // 3 hours
	// TODO: Implement a dynamic revalidation strategy to ensure data freshness without unnecessary revalidations.
	export const REVALIDATION_INTERVAL = 0;
	export const SERVICES_REVALIDATION_INTERVAL = 60 * 60 * 3; // 3 hours