fix: caching issue with translate surveys #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
packages/lib/constants.tsIt's a good practice to avoid magic numbers in the code. Instead, use constants with meaningful names. This makes the code more readable and maintainable. const THREE_HOURS_IN_SECONDS = 60 * 60 * 3;
export const SERVICES_REVALIDATION_INTERVAL = THREE_HOURS_IN_SECONDS; // 3 hours |
![review-agent-prime[bot]](https://avatars.githubusercontent.com/in/404610?s=60&v=4){kind=small}
| @@ -4,7 +4,7 @@ import { env } from "./env"; | |||
|
|
|||
| export const IS_FORMBRICKS_CLOUD = env.IS_FORMBRICKS_CLOUD === "1"; | |||
| export const REVALIDATION_INTERVAL = 0; //TODO: find a good way to cache and revalidate data when it changes | |||
| export const SERVICES_REVALIDATION_INTERVAL = 60 * 30; // 30 minutes | |||
| export const SERVICES_REVALIDATION_INTERVAL = 60 * 60 * 3; // 3 hours | |||
There was a problem hiding this comment.
Replace the magic number with a constant to improve code readability and maintainability.
Suggested change
| export const SERVICES_REVALIDATION_INTERVAL = 60 * 60 * 3; // 3 hours | |
| const THREE_HOURS_IN_SECONDS = 60 * 60 * 3; | |
| export const SERVICES_REVALIDATION_INTERVAL = THREE_HOURS_IN_SECONDS; // 3 hours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix: caching issue with translate surveys