fix: translate survey and migration script #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
packages/lib/i18n/utils.tsConsider using destructuring to improve readability and reduce redundancy. This can be applied in several places in the code where properties are being accessed multiple times from the same object. // For example, in the translateQuestion function, instead of accessing question.type multiple times, you can destructure it at the beginning of the function.
const { type } = question;
switch (type) {
case "openText":
// ...
case "multipleChoiceSingle":
case "multipleChoiceMulti":
// ...
// ...
}Consider using a lookup object instead of multiple if-else or switch-case statements. This can improve performance as lookup in an object is generally faster than multiple conditional checks. // For example, in the translateQuestion function, instead of using a switch-case statement, you can define a lookup object.
const questionTypeHandlers = {
"openText": handleOpenTextQuestion,
"multipleChoiceSingle": handleMultipleChoiceSingleQuestion,
"multipleChoiceMulti": handleMultipleChoiceMultiQuestion,
// ...
};
const handler = questionTypeHandlers[question.type];
if (handler) {
return handler(question, languages);
} |
![review-agent-prime[bot]](https://avatars.githubusercontent.com/in/404610?s=60&v=4){kind=small}
packages/lib/i18n/utils.ts
Outdated
Comment on lines
177
to
294
| (clonedQuestion as TSurveyRatingQuestion).upperLabel = createI18nString( | ||
| question.upperLabel ?? "", | ||
| languages, | ||
| targetLanguageCode | ||
| ); | ||
| switch (question.type) { | ||
| case "openText": | ||
| if (typeof question.placeholder === "string") { | ||
| (clonedQuestion as TSurveyOpenTextQuestion).placeholder = createI18nString( | ||
| question.placeholder ?? "", | ||
| languages | ||
| ); | ||
| } | ||
| return ZSurveyOpenTextQuestion.parse(clonedQuestion); | ||
|
|
||
| case "multipleChoiceSingle": | ||
| case "multipleChoiceMulti": | ||
| (clonedQuestion as TSurveyMultipleChoiceSingleQuestion | TSurveyMultipleChoiceMultiQuestion).choices = | ||
| question.choices.map((choice) => { | ||
| return translateChoice(choice, languages); | ||
| }); | ||
| if ( | ||
| typeof (clonedQuestion as TSurveyMultipleChoiceSingleQuestion | TSurveyMultipleChoiceMultiQuestion) | ||
| .otherOptionPlaceholder === "string" | ||
| ) { | ||
| ( | ||
| clonedQuestion as TSurveyMultipleChoiceSingleQuestion | TSurveyMultipleChoiceMultiQuestion | ||
| ).otherOptionPlaceholder = createI18nString(question.otherOptionPlaceholder ?? "", languages); | ||
| } | ||
| if (question.type === "multipleChoiceSingle") { | ||
| return ZSurveyMultipleChoiceSingleQuestion.parse(clonedQuestion); | ||
| } else return ZSurveyMultipleChoiceMultiQuestion.parse(clonedQuestion); | ||
|
|
||
| case "cta": | ||
| if (typeof question.dismissButtonLabel === "string") { | ||
| (clonedQuestion as TSurveyCTAQuestion).dismissButtonLabel = createI18nString( | ||
| question.dismissButtonLabel ?? "", | ||
| languages | ||
| ); | ||
| } | ||
| if (typeof question.html === "string") { | ||
| (clonedQuestion as TSurveyCTAQuestion).html = createI18nString(question.html ?? "", languages); | ||
| } | ||
| return ZSurveyCTAQuestion.parse(clonedQuestion); | ||
|
|
||
| case "consent": | ||
| if (typeof question.html === "string") { | ||
| (clonedQuestion as TSurveyConsentQuestion).html = createI18nString(question.html ?? "", languages); | ||
| } | ||
|
|
||
| if (typeof question.label === "string") { | ||
| (clonedQuestion as TSurveyConsentQuestion).label = createI18nString(question.label ?? "", languages); | ||
| } | ||
| return ZSurveyConsentQuestion.parse(clonedQuestion); | ||
|
|
||
| case "nps": | ||
| if (typeof question.lowerLabel === "string") { | ||
| (clonedQuestion as TSurveyNPSQuestion).lowerLabel = createI18nString( | ||
| question.lowerLabel ?? "", | ||
| languages | ||
| ); | ||
| } | ||
| if (typeof question.upperLabel === "string") { | ||
| (clonedQuestion as TSurveyNPSQuestion).upperLabel = createI18nString( | ||
| question.upperLabel ?? "", | ||
| languages | ||
| ); | ||
| } | ||
| return ZSurveyNPSQuestion.parse(clonedQuestion); | ||
|
|
||
| case "rating": | ||
| if (typeof question.lowerLabel === "string") { | ||
| (clonedQuestion as TSurveyRatingQuestion).lowerLabel = createI18nString( | ||
| question.lowerLabel ?? "", | ||
| languages | ||
| ); | ||
| } | ||
|
|
||
| if (typeof question.upperLabel === "string") { | ||
| (clonedQuestion as TSurveyRatingQuestion).upperLabel = createI18nString( | ||
| question.upperLabel ?? "", | ||
| languages | ||
| ); | ||
| } | ||
| return ZSurveyRatingQuestion.parse(clonedQuestion); | ||
|
|
||
| case "fileUpload": | ||
| return ZSurveyFileUploadQuestion.parse(clonedQuestion); | ||
|
|
||
| case "pictureSelection": | ||
| return ZSurveyPictureSelectionQuestion.parse(clonedQuestion); | ||
|
|
||
| case "cal": | ||
| return ZSurveyCalQuestion.parse(clonedQuestion); | ||
|
|
||
| default: | ||
| return ZSurveyQuestion.parse(clonedQuestion); | ||
| } | ||
| return clonedQuestion; | ||
| }; |
There was a problem hiding this comment.
Refactor the translateQuestion function to use destructuring for improved readability and reduced redundancy.
Suggested change
| export const translateQuestion = ( | |
| question: TSurveyQuestion, | |
| languages: string[], | |
| targetLanguageCode?: string | |
| ) => { | |
| question: TLegacySurveyQuestion | TSurveyQuestion, | |
| languages: string[] | |
| ): TSurveyQuestion => { | |
| // Clone the question to avoid mutating the original | |
| const clonedQuestion = structuredClone(question); | |
| clonedQuestion.headline = createI18nString(question.headline, languages, targetLanguageCode); | |
| if (clonedQuestion.subheader) { | |
| clonedQuestion.subheader = createI18nString(question.subheader ?? "", languages, targetLanguageCode); | |
| //common question properties | |
| if (typeof question.headline === "string") { | |
| clonedQuestion.headline = createI18nString(question.headline ?? "", languages); | |
| } | |
| if (clonedQuestion.buttonLabel) { | |
| clonedQuestion.buttonLabel = createI18nString(question.buttonLabel ?? "", languages, targetLanguageCode); | |
| if (typeof question.subheader === "string") { | |
| clonedQuestion.subheader = createI18nString(question.subheader ?? "", languages); | |
| } | |
| if (clonedQuestion.backButtonLabel) { | |
| clonedQuestion.backButtonLabel = createI18nString( | |
| question.backButtonLabel ?? "", | |
| languages, | |
| targetLanguageCode | |
| ); | |
| if (typeof question.buttonLabel === "string") { | |
| clonedQuestion.buttonLabel = createI18nString(question.buttonLabel ?? "", languages); | |
| } | |
| if (question.type === "multipleChoiceSingle" || question.type === "multipleChoiceMulti") { | |
| (clonedQuestion as TSurveyMultipleChoiceMultiQuestion | TSurveyMultipleChoiceMultiQuestion).choices = | |
| question.choices.map((choice) => ({ | |
| ...choice, | |
| label: createI18nString(choice.label, languages, targetLanguageCode), | |
| })); | |
| ( | |
| clonedQuestion as TSurveyMultipleChoiceMultiQuestion | TSurveyMultipleChoiceMultiQuestion | |
| ).otherOptionPlaceholder = question.otherOptionPlaceholder | |
| ? createI18nString(question.otherOptionPlaceholder, languages, targetLanguageCode) | |
| : undefined; | |
| if (typeof question.backButtonLabel === "string") { | |
| clonedQuestion.backButtonLabel = createI18nString(question.backButtonLabel ?? "", languages); | |
| } | |
| if (question.type === "openText") { | |
| if (question.placeholder) { | |
| (clonedQuestion as TSurveyOpenTextQuestion).placeholder = createI18nString( | |
| question.placeholder, | |
| languages, | |
| targetLanguageCode | |
| ); | |
| } | |
| } | |
| if (question.type === "cta") { | |
| if (question.dismissButtonLabel) { | |
| (clonedQuestion as TSurveyCTAQuestion).dismissButtonLabel = createI18nString( | |
| question.dismissButtonLabel, | |
| languages, | |
| targetLanguageCode | |
| ); | |
| } | |
| if (question.html) { | |
| (clonedQuestion as TSurveyCTAQuestion).html = createI18nString( | |
| question.html, | |
| languages, | |
| targetLanguageCode | |
| ); | |
| } | |
| } | |
| if (question.type === "consent") { | |
| if (question.html) { | |
| (clonedQuestion as TSurveyConsentQuestion).html = createI18nString( | |
| question.html, | |
| languages, | |
| targetLanguageCode | |
| ); | |
| } | |
| if (question.label) { | |
| (clonedQuestion as TSurveyConsentQuestion).label = createI18nString( | |
| question.label, | |
| languages, | |
| targetLanguageCode | |
| ); | |
| } | |
| } | |
| if (question.type === "nps") { | |
| (clonedQuestion as TSurveyNPSQuestion).lowerLabel = createI18nString( | |
| question.lowerLabel ?? "", | |
| languages, | |
| targetLanguageCode | |
| ); | |
| (clonedQuestion as TSurveyNPSQuestion).upperLabel = createI18nString( | |
| question.upperLabel ?? "", | |
| languages, | |
| targetLanguageCode | |
| ); | |
| } | |
| if (question.type === "rating") { | |
| (clonedQuestion as TSurveyRatingQuestion).lowerLabel = createI18nString( | |
| question.lowerLabel ?? "", | |
| languages, | |
| targetLanguageCode | |
| ); | |
| (clonedQuestion as TSurveyRatingQuestion).upperLabel = createI18nString( | |
| question.upperLabel ?? "", | |
| languages, | |
| targetLanguageCode | |
| ); | |
| switch (question.type) { | |
| case "openText": | |
| if (typeof question.placeholder === "string") { | |
| (clonedQuestion as TSurveyOpenTextQuestion).placeholder = createI18nString( | |
| question.placeholder ?? "", | |
| languages | |
| ); | |
| } | |
| return ZSurveyOpenTextQuestion.parse(clonedQuestion); | |
| case "multipleChoiceSingle": | |
| case "multipleChoiceMulti": | |
| (clonedQuestion as TSurveyMultipleChoiceSingleQuestion | TSurveyMultipleChoiceMultiQuestion).choices = | |
| question.choices.map((choice) => { | |
| return translateChoice(choice, languages); | |
| }); | |
| if ( | |
| typeof (clonedQuestion as TSurveyMultipleChoiceSingleQuestion | TSurveyMultipleChoiceMultiQuestion) | |
| .otherOptionPlaceholder === "string" | |
| ) { | |
| ( | |
| clonedQuestion as TSurveyMultipleChoiceSingleQuestion | TSurveyMultipleChoiceMultiQuestion | |
| ).otherOptionPlaceholder = createI18nString(question.otherOptionPlaceholder ?? "", languages); | |
| } | |
| if (question.type === "multipleChoiceSingle") { | |
| return ZSurveyMultipleChoiceSingleQuestion.parse(clonedQuestion); | |
| } else return ZSurveyMultipleChoiceMultiQuestion.parse(clonedQuestion); | |
| case "cta": | |
| if (typeof question.dismissButtonLabel === "string") { | |
| (clonedQuestion as TSurveyCTAQuestion).dismissButtonLabel = createI18nString( | |
| question.dismissButtonLabel ?? "", | |
| languages | |
| ); | |
| } | |
| if (typeof question.html === "string") { | |
| (clonedQuestion as TSurveyCTAQuestion).html = createI18nString(question.html ?? "", languages); | |
| } | |
| return ZSurveyCTAQuestion.parse(clonedQuestion); | |
| case "consent": | |
| if (typeof question.html === "string") { | |
| (clonedQuestion as TSurveyConsentQuestion).html = createI18nString(question.html ?? "", languages); | |
| } | |
| if (typeof question.label === "string") { | |
| (clonedQuestion as TSurveyConsentQuestion).label = createI18nString(question.label ?? "", languages); | |
| } | |
| return ZSurveyConsentQuestion.parse(clonedQuestion); | |
| case "nps": | |
| if (typeof question.lowerLabel === "string") { | |
| (clonedQuestion as TSurveyNPSQuestion).lowerLabel = createI18nString( | |
| question.lowerLabel ?? "", | |
| languages | |
| ); | |
| } | |
| if (typeof question.upperLabel === "string") { | |
| (clonedQuestion as TSurveyNPSQuestion).upperLabel = createI18nString( | |
| question.upperLabel ?? "", | |
| languages | |
| ); | |
| } | |
| return ZSurveyNPSQuestion.parse(clonedQuestion); | |
| case "rating": | |
| if (typeof question.lowerLabel === "string") { | |
| (clonedQuestion as TSurveyRatingQuestion).lowerLabel = createI18nString( | |
| question.lowerLabel ?? "", | |
| languages | |
| ); | |
| } | |
| if (typeof question.upperLabel === "string") { | |
| (clonedQuestion as TSurveyRatingQuestion).upperLabel = createI18nString( | |
| question.upperLabel ?? "", | |
| languages | |
| ); | |
| } | |
| return ZSurveyRatingQuestion.parse(clonedQuestion); | |
| case "fileUpload": | |
| return ZSurveyFileUploadQuestion.parse(clonedQuestion); | |
| case "pictureSelection": | |
| return ZSurveyPictureSelectionQuestion.parse(clonedQuestion); | |
| case "cal": | |
| return ZSurveyCalQuestion.parse(clonedQuestion); | |
| default: | |
| return ZSurveyQuestion.parse(clonedQuestion); | |
| } | |
| return clonedQuestion; | |
| }; | |
| export const translateQuestion = ( | |
| question: TLegacySurveyQuestion | TSurveyQuestion, | |
| languages: string[] | |
| ): TSurveyQuestion => { | |
| // Clone the question to avoid mutating the original | |
| const clonedQuestion = structuredClone(question); | |
| //common question properties | |
| if (typeof question.headline === "string") { | |
| clonedQuestion.headline = createI18nString(question.headline ?? "", languages); | |
| } | |
| if (typeof question.subheader === "string") { | |
| clonedQuestion.subheader = createI18nString(question.subheader ?? "", languages); | |
| } | |
| if (typeof question.buttonLabel === "string") { | |
| clonedQuestion.buttonLabel = createI18nString(question.buttonLabel ?? "", languages); | |
| } | |
| if (typeof question.backButtonLabel === "string") { | |
| clonedQuestion.backButtonLabel = createI18nString(question.backButtonLabel ?? "", languages); | |
| } | |
| const { type } = question; | |
| switch (type) { | |
| case "openText": | |
| // ... | |
| case "multipleChoiceSingle": | |
| case "multipleChoiceMulti": | |
| // ... | |
| // ... | |
| } | |
| } |
packages/lib/i18n/utils.ts
Outdated
Comment on lines
177
to
294
| (clonedQuestion as TSurveyRatingQuestion).upperLabel = createI18nString( | ||
| question.upperLabel ?? "", | ||
| languages, | ||
| targetLanguageCode | ||
| ); | ||
| switch (question.type) { | ||
| case "openText": | ||
| if (typeof question.placeholder === "string") { | ||
| (clonedQuestion as TSurveyOpenTextQuestion).placeholder = createI18nString( | ||
| question.placeholder ?? "", | ||
| languages | ||
| ); | ||
| } | ||
| return ZSurveyOpenTextQuestion.parse(clonedQuestion); | ||
|
|
||
| case "multipleChoiceSingle": | ||
| case "multipleChoiceMulti": | ||
| (clonedQuestion as TSurveyMultipleChoiceSingleQuestion | TSurveyMultipleChoiceMultiQuestion).choices = | ||
| question.choices.map((choice) => { | ||
| return translateChoice(choice, languages); | ||
| }); | ||
| if ( | ||
| typeof (clonedQuestion as TSurveyMultipleChoiceSingleQuestion | TSurveyMultipleChoiceMultiQuestion) | ||
| .otherOptionPlaceholder === "string" | ||
| ) { | ||
| ( | ||
| clonedQuestion as TSurveyMultipleChoiceSingleQuestion | TSurveyMultipleChoiceMultiQuestion | ||
| ).otherOptionPlaceholder = createI18nString(question.otherOptionPlaceholder ?? "", languages); | ||
| } | ||
| if (question.type === "multipleChoiceSingle") { | ||
| return ZSurveyMultipleChoiceSingleQuestion.parse(clonedQuestion); | ||
| } else return ZSurveyMultipleChoiceMultiQuestion.parse(clonedQuestion); | ||
|
|
||
| case "cta": | ||
| if (typeof question.dismissButtonLabel === "string") { | ||
| (clonedQuestion as TSurveyCTAQuestion).dismissButtonLabel = createI18nString( | ||
| question.dismissButtonLabel ?? "", | ||
| languages | ||
| ); | ||
| } | ||
| if (typeof question.html === "string") { | ||
| (clonedQuestion as TSurveyCTAQuestion).html = createI18nString(question.html ?? "", languages); | ||
| } | ||
| return ZSurveyCTAQuestion.parse(clonedQuestion); | ||
|
|
||
| case "consent": | ||
| if (typeof question.html === "string") { | ||
| (clonedQuestion as TSurveyConsentQuestion).html = createI18nString(question.html ?? "", languages); | ||
| } | ||
|
|
||
| if (typeof question.label === "string") { | ||
| (clonedQuestion as TSurveyConsentQuestion).label = createI18nString(question.label ?? "", languages); | ||
| } | ||
| return ZSurveyConsentQuestion.parse(clonedQuestion); | ||
|
|
||
| case "nps": | ||
| if (typeof question.lowerLabel === "string") { | ||
| (clonedQuestion as TSurveyNPSQuestion).lowerLabel = createI18nString( | ||
| question.lowerLabel ?? "", | ||
| languages | ||
| ); | ||
| } | ||
| if (typeof question.upperLabel === "string") { | ||
| (clonedQuestion as TSurveyNPSQuestion).upperLabel = createI18nString( | ||
| question.upperLabel ?? "", | ||
| languages | ||
| ); | ||
| } | ||
| return ZSurveyNPSQuestion.parse(clonedQuestion); | ||
|
|
||
| case "rating": | ||
| if (typeof question.lowerLabel === "string") { | ||
| (clonedQuestion as TSurveyRatingQuestion).lowerLabel = createI18nString( | ||
| question.lowerLabel ?? "", | ||
| languages | ||
| ); | ||
| } | ||
|
|
||
| if (typeof question.upperLabel === "string") { | ||
| (clonedQuestion as TSurveyRatingQuestion).upperLabel = createI18nString( | ||
| question.upperLabel ?? "", | ||
| languages | ||
| ); | ||
| } | ||
| return ZSurveyRatingQuestion.parse(clonedQuestion); | ||
|
|
||
| case "fileUpload": | ||
| return ZSurveyFileUploadQuestion.parse(clonedQuestion); | ||
|
|
||
| case "pictureSelection": | ||
| return ZSurveyPictureSelectionQuestion.parse(clonedQuestion); | ||
|
|
||
| case "cal": | ||
| return ZSurveyCalQuestion.parse(clonedQuestion); | ||
|
|
||
| default: | ||
| return ZSurveyQuestion.parse(clonedQuestion); | ||
| } | ||
| return clonedQuestion; | ||
| }; |
There was a problem hiding this comment.
Refactor the translateQuestion function to use a lookup object instead of a switch-case statement. This will improve performance as lookup in an object is generally faster than multiple conditional checks.
Suggested change
| export const translateQuestion = ( | |
| question: TSurveyQuestion, | |
| languages: string[], | |
| targetLanguageCode?: string | |
| ) => { | |
| question: TLegacySurveyQuestion | TSurveyQuestion, | |
| languages: string[] | |
| ): TSurveyQuestion => { | |
| // Clone the question to avoid mutating the original | |
| const clonedQuestion = structuredClone(question); | |
| clonedQuestion.headline = createI18nString(question.headline, languages, targetLanguageCode); | |
| if (clonedQuestion.subheader) { | |
| clonedQuestion.subheader = createI18nString(question.subheader ?? "", languages, targetLanguageCode); | |
| //common question properties | |
| if (typeof question.headline === "string") { | |
| clonedQuestion.headline = createI18nString(question.headline ?? "", languages); | |
| } | |
| if (clonedQuestion.buttonLabel) { | |
| clonedQuestion.buttonLabel = createI18nString(question.buttonLabel ?? "", languages, targetLanguageCode); | |
| if (typeof question.subheader === "string") { | |
| clonedQuestion.subheader = createI18nString(question.subheader ?? "", languages); | |
| } | |
| if (clonedQuestion.backButtonLabel) { | |
| clonedQuestion.backButtonLabel = createI18nString( | |
| question.backButtonLabel ?? "", | |
| languages, | |
| targetLanguageCode | |
| ); | |
| if (typeof question.buttonLabel === "string") { | |
| clonedQuestion.buttonLabel = createI18nString(question.buttonLabel ?? "", languages); | |
| } | |
| if (question.type === "multipleChoiceSingle" || question.type === "multipleChoiceMulti") { | |
| (clonedQuestion as TSurveyMultipleChoiceMultiQuestion | TSurveyMultipleChoiceMultiQuestion).choices = | |
| question.choices.map((choice) => ({ | |
| ...choice, | |
| label: createI18nString(choice.label, languages, targetLanguageCode), | |
| })); | |
| ( | |
| clonedQuestion as TSurveyMultipleChoiceMultiQuestion | TSurveyMultipleChoiceMultiQuestion | |
| ).otherOptionPlaceholder = question.otherOptionPlaceholder | |
| ? createI18nString(question.otherOptionPlaceholder, languages, targetLanguageCode) | |
| : undefined; | |
| if (typeof question.backButtonLabel === "string") { | |
| clonedQuestion.backButtonLabel = createI18nString(question.backButtonLabel ?? "", languages); | |
| } | |
| if (question.type === "openText") { | |
| if (question.placeholder) { | |
| (clonedQuestion as TSurveyOpenTextQuestion).placeholder = createI18nString( | |
| question.placeholder, | |
| languages, | |
| targetLanguageCode | |
| ); | |
| } | |
| } | |
| if (question.type === "cta") { | |
| if (question.dismissButtonLabel) { | |
| (clonedQuestion as TSurveyCTAQuestion).dismissButtonLabel = createI18nString( | |
| question.dismissButtonLabel, | |
| languages, | |
| targetLanguageCode | |
| ); | |
| } | |
| if (question.html) { | |
| (clonedQuestion as TSurveyCTAQuestion).html = createI18nString( | |
| question.html, | |
| languages, | |
| targetLanguageCode | |
| ); | |
| } | |
| } | |
| if (question.type === "consent") { | |
| if (question.html) { | |
| (clonedQuestion as TSurveyConsentQuestion).html = createI18nString( | |
| question.html, | |
| languages, | |
| targetLanguageCode | |
| ); | |
| } | |
| if (question.label) { | |
| (clonedQuestion as TSurveyConsentQuestion).label = createI18nString( | |
| question.label, | |
| languages, | |
| targetLanguageCode | |
| ); | |
| } | |
| } | |
| if (question.type === "nps") { | |
| (clonedQuestion as TSurveyNPSQuestion).lowerLabel = createI18nString( | |
| question.lowerLabel ?? "", | |
| languages, | |
| targetLanguageCode | |
| ); | |
| (clonedQuestion as TSurveyNPSQuestion).upperLabel = createI18nString( | |
| question.upperLabel ?? "", | |
| languages, | |
| targetLanguageCode | |
| ); | |
| } | |
| if (question.type === "rating") { | |
| (clonedQuestion as TSurveyRatingQuestion).lowerLabel = createI18nString( | |
| question.lowerLabel ?? "", | |
| languages, | |
| targetLanguageCode | |
| ); | |
| (clonedQuestion as TSurveyRatingQuestion).upperLabel = createI18nString( | |
| question.upperLabel ?? "", | |
| languages, | |
| targetLanguageCode | |
| ); | |
| switch (question.type) { | |
| case "openText": | |
| if (typeof question.placeholder === "string") { | |
| (clonedQuestion as TSurveyOpenTextQuestion).placeholder = createI18nString( | |
| question.placeholder ?? "", | |
| languages | |
| ); | |
| } | |
| return ZSurveyOpenTextQuestion.parse(clonedQuestion); | |
| case "multipleChoiceSingle": | |
| case "multipleChoiceMulti": | |
| (clonedQuestion as TSurveyMultipleChoiceSingleQuestion | TSurveyMultipleChoiceMultiQuestion).choices = | |
| question.choices.map((choice) => { | |
| return translateChoice(choice, languages); | |
| }); | |
| if ( | |
| typeof (clonedQuestion as TSurveyMultipleChoiceSingleQuestion | TSurveyMultipleChoiceMultiQuestion) | |
| .otherOptionPlaceholder === "string" | |
| ) { | |
| ( | |
| clonedQuestion as TSurveyMultipleChoiceSingleQuestion | TSurveyMultipleChoiceMultiQuestion | |
| ).otherOptionPlaceholder = createI18nString(question.otherOptionPlaceholder ?? "", languages); | |
| } | |
| if (question.type === "multipleChoiceSingle") { | |
| return ZSurveyMultipleChoiceSingleQuestion.parse(clonedQuestion); | |
| } else return ZSurveyMultipleChoiceMultiQuestion.parse(clonedQuestion); | |
| case "cta": | |
| if (typeof question.dismissButtonLabel === "string") { | |
| (clonedQuestion as TSurveyCTAQuestion).dismissButtonLabel = createI18nString( | |
| question.dismissButtonLabel ?? "", | |
| languages | |
| ); | |
| } | |
| if (typeof question.html === "string") { | |
| (clonedQuestion as TSurveyCTAQuestion).html = createI18nString(question.html ?? "", languages); | |
| } | |
| return ZSurveyCTAQuestion.parse(clonedQuestion); | |
| case "consent": | |
| if (typeof question.html === "string") { | |
| (clonedQuestion as TSurveyConsentQuestion).html = createI18nString(question.html ?? "", languages); | |
| } | |
| if (typeof question.label === "string") { | |
| (clonedQuestion as TSurveyConsentQuestion).label = createI18nString(question.label ?? "", languages); | |
| } | |
| return ZSurveyConsentQuestion.parse(clonedQuestion); | |
| case "nps": | |
| if (typeof question.lowerLabel === "string") { | |
| (clonedQuestion as TSurveyNPSQuestion).lowerLabel = createI18nString( | |
| question.lowerLabel ?? "", | |
| languages | |
| ); | |
| } | |
| if (typeof question.upperLabel === "string") { | |
| (clonedQuestion as TSurveyNPSQuestion).upperLabel = createI18nString( | |
| question.upperLabel ?? "", | |
| languages | |
| ); | |
| } | |
| return ZSurveyNPSQuestion.parse(clonedQuestion); | |
| case "rating": | |
| if (typeof question.lowerLabel === "string") { | |
| (clonedQuestion as TSurveyRatingQuestion).lowerLabel = createI18nString( | |
| question.lowerLabel ?? "", | |
| languages | |
| ); | |
| } | |
| if (typeof question.upperLabel === "string") { | |
| (clonedQuestion as TSurveyRatingQuestion).upperLabel = createI18nString( | |
| question.upperLabel ?? "", | |
| languages | |
| ); | |
| } | |
| return ZSurveyRatingQuestion.parse(clonedQuestion); | |
| case "fileUpload": | |
| return ZSurveyFileUploadQuestion.parse(clonedQuestion); | |
| case "pictureSelection": | |
| return ZSurveyPictureSelectionQuestion.parse(clonedQuestion); | |
| case "cal": | |
| return ZSurveyCalQuestion.parse(clonedQuestion); | |
| default: | |
| return ZSurveyQuestion.parse(clonedQuestion); | |
| } | |
| return clonedQuestion; | |
| }; | |
| export const translateQuestion = ( | |
| question: TLegacySurveyQuestion | TSurveyQuestion, | |
| languages: string[] | |
| ): TSurveyQuestion => { | |
| // Clone the question to avoid mutating the original | |
| const clonedQuestion = structuredClone(question); | |
| //common question properties | |
| if (typeof question.headline === "string") { | |
| clonedQuestion.headline = createI18nString(question.headline ?? "", languages); | |
| } | |
| if (typeof question.subheader === "string") { | |
| clonedQuestion.subheader = createI18nString(question.subheader ?? "", languages); | |
| } | |
| if (typeof question.buttonLabel === "string") { | |
| clonedQuestion.buttonLabel = createI18nString(question.buttonLabel ?? "", languages); | |
| } | |
| if (typeof question.backButtonLabel === "string") { | |
| clonedQuestion.backButtonLabel = createI18nString(question.backButtonLabel ?? "", languages); | |
| } | |
| const questionTypeHandlers = { | |
| "openText": handleOpenTextQuestion, | |
| "multipleChoiceSingle": handleMultipleChoiceSingleQuestion, | |
| "multipleChoiceMulti": handleMultipleChoiceMultiQuestion, | |
| // ... | |
| }; | |
| const handler = questionTypeHandlers[question.type]; | |
| if (handler) { | |
| return handler(question, languages); | |
| } | |
| } |
mattinannt
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
@Dhruwang thanks a lot 😊 It's now working for all my tests 😊💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improved translate survey function and added migration script 2
How should this be tested?
pnpm run data-migration2:mlsChecklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated