Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added migration script to fix range in rating question #2298

Merged
merged 4 commits into from
Mar 20, 2024
Merged

fix: added migration script to fix range in rating question #2298

merged 4 commits into from
Mar 20, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Fixes # (issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel Vercel
Copy link

vercel bot commented Mar 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 8:10pm
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 8:10pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

mattinannt
mattinannt approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊💪

@mattinannt mattinannt added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit f22e3fd Mar 20, 2024
12 of 14 checks passed
@mattinannt mattinannt deleted the number-migration branch March 20, 2024 20:26
vidhikapadia2799 pushed a commit to vidhikapadia2799/formbricks that referenced this pull request Mar 26, 2024
@Dhruwang @mattinannt @vijay-thumar-simform
fix: added migration script to fix range in rating question (formbric…
ab23ce9 
…ks#2298)

Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattinannt mattinannt mattinannt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dhruwang @mattinannt