Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: discard formatting on paste in Lexical Editor #2315

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Dhruwang
Copy link
Contributor

@Dhruwang Dhruwang commented Mar 22, 2024

What does this PR do?

Fixes 1708

Before:

Screen-Recording-2024-03-22-at-12.03.48.PM.mp4

After:

Screen-Recording-2024-03-22-at-12.04.47.PM.mp4

How should this be tested?

Try to paste a formatted text in editor (thank you card, consent, cta)

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Mar 22, 2024 6:42am
formbricks-com ⬜️ Ignored (Inspect) Mar 22, 2024 6:42am

Copy link
Contributor

github-actions bot commented Mar 22, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang 💪 thanks for adding this fix :-) 🤗

@mattinannt mattinannt added this pull request to the merge queue Mar 25, 2024
Merged via the queue into main with commit 7a93af3 Mar 25, 2024
15 of 17 checks passed
@mattinannt mattinannt deleted the discard-formatting branch March 25, 2024 12:40
vidhikapadia2799 pushed a commit to vidhikapadia2799/formbricks that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants