Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sort team and product names alphabetically #2316

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix: sort team and product names alphabetically #2316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions apps/web/app/(app)/environments/[environmentId]/components/Navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,14 @@ export default function Navigation({
}
}, [team]);

const sortedProducts = useMemo(() => {
return [...products].sort((a, b) => a.name.localeCompare(b.name));
}, [products]);

const sortedTeams = useMemo(() => {
return [...teams].sort((a, b) => a.name.localeCompare(b.name));
}, [teams]);

const navigation = useMemo(
() => [
{
Expand Down Expand Up @@ -392,7 +400,7 @@ export default function Navigation({
<DropdownMenuRadioGroup
value={product!.id}
onValueChange={(v) => handleEnvironmentChangeByProduct(v)}>
{products.map((product) => (
{sortedProducts.map((product) => (
<DropdownMenuRadioItem
value={product.id}
className="cursor-pointer break-all"
Expand Down Expand Up @@ -427,7 +435,7 @@ export default function Navigation({
<DropdownMenuRadioGroup
value={currentTeamId}
onValueChange={(teamId) => handleEnvironmentChangeByTeam(teamId)}>
{teams?.map((team) => (
{sortedTeams.map((team) => (
<DropdownMenuRadioItem value={team.id} className="cursor-pointer" key={team.id}>
{team.name}
</DropdownMenuRadioItem>
Expand Down
Loading