Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display URL in metadata #2329

Merged

Conversation

nik132-eng
Copy link
Contributor

What does this PR do?

Get the current browser URL when a survey response is created in the @formbricks/js package

Fixes #2305

image

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Mar 25, 2024

@nik132-eng is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Mar 25, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@github-actions github-actions bot added enhancement New feature or request 🕹️ 100 points 🕹️ oss.gg Community issue via oss.gg labels Mar 25, 2024
@mattinannt mattinannt changed the title Feat- display URL in metadata feat: display URL in metadata Mar 25, 2024
@mattinannt
Copy link
Member

@nik132-eng thanks for the PR. The display for link surveys work but the main issue in the ticket was the support for in-app surveys which unfortunately wasn't solved here.

@mattinannt
Copy link
Member

@nik132-eng There wasn't much missing; I made the necessary changes 😊

@mattinannt
Copy link
Member

/award 100

Copy link

oss-gg bot commented Mar 26, 2024

Awarding nik132-eng: 100 points!

@mattinannt mattinannt added this pull request to the merge queue Mar 26, 2024
Merged via the queue into formbricks:main with commit a70810c Mar 26, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🕹️ oss.gg Community issue via oss.gg 🕹️ 100 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE][🕹️] Store display URL for in-app surveys as meta data
2 participants