-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Transactional emails to React email #2349
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Thank you for following the naming conventions for pull request titles! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruwang Thanks for the PR and the refactoring. The feature works really well. 🚀
I have just added a few minor comments. Please check them out; after that, we're good to merge this.
apps/web/app/api/cron/weekly-summary/components/CreateReminderNotificationBody.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/api/cron/weekly-summary/components/NotificationFooter.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/api/cron/weekly-summary/components/LiveSurveyNotification.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/api/cron/weekly-summary/components/LiveSurveyNotification.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/api/cron/weekly-summary/components/LiveSurveyNotification.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruwang Thanks for the PR :-) Looks great!
Still there are a few structural things I would like to get changed before we can merge this :-)
apps/web/app/api/cron/weekly-summary/components/CreateReminderNotificationBody.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/api/cron/weekly-summary/components/LiveSurveyNotification.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/api/cron/weekly-summary/components/LiveSurveyNotification.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/api/cron/weekly-summary/components/LiveSurveyNotification.tsx
Outdated
Show resolved
Hide resolved
…into react-email
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruwang Looks good! I love the modularity with our new email package :-) 🚀 I just made a few changes to the types for more consistency. If we have a types file weeklySummary.ts
then all the types should also start with ZWeeklySummary...
:-) And for every zod type we should also export a typescript type :-)
What does this PR do?
Transactional emails -> React email
Fixes 1869
How should this be tested?
Test emails
Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated