Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Transactional emails to React email #2349

Merged
merged 37 commits into from
Apr 25, 2024
Merged

chore: Transactional emails to React email #2349

merged 37 commits into from
Apr 25, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Transactional emails -> React email

Screenshot 2024-03-28 at 10 12 55 AM Screenshot 2024-03-28 at 10 08 52 AM Screenshot 2024-03-28 at 9 42 17 AM Screenshot 2024-03-28 at 10 06 34 AM Screenshot 2024-03-28 at 10 05 42 AM Screenshot 2024-03-28 at 10 08 16 AM Screenshot 2024-03-28 at 10 04 52 AM Screenshot 2024-03-28 at 9 43 54 AM

Fixes 1869

How should this be tested?

Test emails

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 0:52am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 0:52am

Copy link
Contributor

github-actions bot commented Mar 28, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

@gupta-piyush19 gupta-piyush19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang Thanks for the PR and the refactoring. The feature works really well. 🚀 
I have just added a few minor comments. Please check them out; after that, we're good to merge this.

Copy link
Contributor

@gupta-piyush19 gupta-piyush19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang Thanks for the PR :-) Looks great!
Still there are a few structural things I would like to get changed before we can merge this :-)

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang Looks good! I love the modularity with our new email package :-) 🚀 I just made a few changes to the types for more consistency. If we have a types file weeklySummary.ts then all the types should also start with ZWeeklySummary... :-) And for every zod type we should also export a typescript type :-)

@mattinannt mattinannt added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 5ff6e88 Apr 25, 2024
12 checks passed
@mattinannt mattinannt deleted the react-email branch April 25, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants