Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: in-app & link multi language surveys #2350

Merged
merged 8 commits into from
Apr 2, 2024
Merged

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

Fixes # (issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 0:57am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 0:57am

Copy link
Contributor

github-actions bot commented Mar 28, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@jobenjada
Copy link
Member

jobenjada commented Mar 28, 2024

hey! fixed a few types and please do the following:

  1. add a few more screenshots here. Many people first look at the docs to see if the product does what they hope it ill do. Your screenshots are a bit scarce and often show the full screen instead of the part of the UI which is important:
image
  1. please style the example surveys in a cool way to showcase more what you can do with Formbricks:
image

Once you made these changes, pls merge them ✅

Thanks! :))

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala thanks for the docs 😊💪 We get an issue with duplicated content and SEO if we publish the post twice in both link-surveys and in-app-surveys. Please add a new category Additional Features above Best Practices and include the Multi-Language here.

@ShubhamPalriwala
Copy link
Contributor Author

Added screenshots + moved over both the pages, combined into 1, and moved to Additional Features. Please take a look now 🤞🏼

@jobenjada jobenjada enabled auto-merge April 1, 2024 12:23
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala thanks for making the changes :-) 💪

@jobenjada jobenjada added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 98e0006 Apr 2, 2024
12 of 14 checks passed
@jobenjada jobenjada deleted the shubham/docs-mls branch April 2, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants