Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: same origin header & password max length to prevent clickjackingg & DoS #2370

Merged
merged 5 commits into from
Apr 4, 2024
Merged

feat: same origin header & password max length to prevent clickjackingg & DoS #2370

merged 5 commits into from
Apr 4, 2024

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

Fixes # (issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 11:26am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 11:26am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024 •
edited

Thank you for following the naming conventions for pull request titles! 🙏

pandeymangg
pandeymangg reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@pandeymangg pandeymangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! @ShubhamPalriwala Thanks for the changes, looks good 😊
Just added a comment for a small change, the rest looks good

packages/ui/PasswordInput/index.tsx Outdated Show resolved Hide resolved
pandeymangg
pandeymangg approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@pandeymangg pandeymangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShubhamPalriwala ShubhamPalriwala added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 3a8aced Apr 4, 2024
12 of 14 checks passed
@ShubhamPalriwala ShubhamPalriwala deleted the shubham/same-origin-header-and-max-len-password branch April 4, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandeymangg pandeymangg pandeymangg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShubhamPalriwala @pandeymangg