Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load surveys package on-the-fly in web-app #2375

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

Fixes # (issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 9:43pm
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 9:43pm

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala Looks good :-)
I only moved the loadScript file to a lib folder to follow our ui-package conventions and renamed the file ending from tsx to ts since it's a typescript file and not a jsx component.
Please go ahead with the merge :-)

@ShubhamPalriwala ShubhamPalriwala added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 4cd23e6 Apr 8, 2024
10 of 12 checks passed
@ShubhamPalriwala ShubhamPalriwala deleted the shubham/load-surveys-async-in-webapp branch April 8, 2024 06:09
Copy link

sentry-io bot commented Apr 8, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: renderSurvey: Element with id formbricks-survey-container not found. Object.Wd [as renderSurveyInline](<anonymous>) View Issue
  • ‼️ ReferenceError: structuredClone is not defined V(<anonymous>) View Issue
  • ‼️ Error: renderSurvey: Element with id formbricks-survey-container not found. Object.Wd [as renderSurveyInline](<anonymous>) View Issue
  • ‼️ TypeError: undefined is not an object (evaluating 'window.formbricksSurveys.renderSurveyInline') renderInline(chunks/app/packages/ui/Survey/index) View Issue
  • ‼️ SyntaxError: unexpected token: ':' loadSurveyScript(chunks/app/packages/ui/Survey/... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants