feat: add survey schedule option #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
jobenjada
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
UI looks great! Didn't test the functionality so @gupta-piyush19 pls do so before merging :)
…feature/schedule-survey
gupta-piyush19
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Thanks, @mattinannt, for the feature; it works really well 🚀
I just have a few suggestions related to code consistency; it would be great if you could comment on or fix them.
Also, one more question: If a survey is already completed and I try to set the runOnDate, should it move to scheduled status or not? Currently, it's not.
|
@gupta-piyush19 Thanks for the review; I made the required changes; please take a look 😊 |
gupta-piyush19
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the option to schedule a survey for a later so it gets published on the provided date automatically.
Fixes # (issue)
How should this be tested?
scheduled.runOnDatefield in the survey manually to date in the past using prisma studio/api/cron/survey-statusendpoint with a valid cron secret