Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docsearch integration #2392

Merged
merged 6 commits into from
Apr 9, 2024
Merged

feat: docsearch integration #2392

merged 6 commits into from
Apr 9, 2024

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

The CSS isn't well-mixing bec docsearch v3 does not allow custom styles :( so had to do inlining.
Loom Video for the same:
https://www.loom.com/share/77d17bfe20ad4a83998565cdfdaddf58?sid=a13a3078-290c-4a76-afca-cfda1f467b93

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 2:10pm
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 2:10pm

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@mattinannt
Copy link
Member

Screenshot 2024-04-04 at 17 52 39

I'm getting this error on the dev server

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the error so we can get this closer to merging 😊

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala thanks; looks good :-)

@ShubhamPalriwala ShubhamPalriwala added this pull request to the merge queue Apr 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2024
@ShubhamPalriwala ShubhamPalriwala added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit 18d3985 Apr 9, 2024
12 checks passed
@ShubhamPalriwala ShubhamPalriwala deleted the shubham/docs-docsearch branch April 9, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants