Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues in multi select, rating and nps questions #2397

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

Dhruwang
Copy link
Contributor

@Dhruwang Dhruwang commented Apr 5, 2024

What does this PR do?

Fixes issue in multi select, nps and rating question

Convert to multi select and convert to single select not working

Screen-Recording-2024-04-05-at-1.22.43.PM.mp4

Other option being selected by default and When filling value for other option in multi select question, entering space leads to unexpected behaviour #2391

Screen-Recording-2024-04-05-at-10.54.31.AM.mp4

For Rating and NPS, even if optional, selecting a value should result in jumping onto next question

How should this be tested?

Test above mentioned issues

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 8:33am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 8:33am

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@jobenjada jobenjada self-assigned this Apr 5, 2024
@jobenjada jobenjada enabled auto-merge April 5, 2024 08:33
@jobenjada jobenjada self-requested a review April 5, 2024 09:32
Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vamos

@jobenjada jobenjada added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit 91822c6 Apr 5, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants