Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: product logo is received null from prisma if not set #2404

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

Go to the Look & Feel page on Production, try to update the product. In your browser console, you should see an error. This is because in the service, we get the product from DB & validate it again, and the DB returns the new logo as null whereas currently it accepts it to be an empty object. This PR fixes that.

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Apr 5, 2024 9:42pm
formbricks-com ⬜️ Ignored (Inspect) Apr 5, 2024 9:42pm

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@mattinannt mattinannt requested a review from Dhruwang April 7, 2024 19:43
@pandeymangg pandeymangg mentioned this pull request Apr 8, 2024
11 tasks
@pandeymangg pandeymangg requested review from pandeymangg and removed request for Dhruwang April 8, 2024 05:58
Copy link
Contributor

@pandeymangg pandeymangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShubhamPalriwala ShubhamPalriwala added this pull request to the merge queue Apr 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2024
@mattinannt mattinannt added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit de82762 Apr 8, 2024
12 of 14 checks passed
@mattinannt mattinannt deleted the shubham/fix-styling-logo-type branch April 8, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants