Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement validation to remove cyclic logic #2417

Merged

Conversation

nik132-eng
Copy link
Contributor

What does this PR do?

This commit introduces a validation mechanism to remove cyclic logic from the survey data. This ensures that any cyclic dependencies are identified and removed before further processing, enhancing the reliability of the application.

Fixes #2408

9april

How should this be tested?

In the logic section make a loop like q1 -> q2 -> q3 ( add logic that redirects to q1) -> q4. It creates a loop.

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • [ x My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 9, 2024

@nik132-eng is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@github-actions github-actions bot added the bug Something isn't working label Apr 9, 2024
Copy link
Contributor

@pandeymangg pandeymangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @nik132-eng looks good 😊
I just added the types to the cycle check function as it was untyped before

@mattinannt mattinannt changed the title Implement validation to remove cyclic logic fix: Implement validation to remove cyclic logic Apr 10, 2024
@pandeymangg pandeymangg added this pull request to the merge queue Apr 10, 2024
Merged via the queue into formbricks:main with commit bfb6012 Apr 10, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] After adding logic in survey it crashes application
3 participants