-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Implement validation to remove cyclic logic #2417
fix: Implement validation to remove cyclic logic #2417
Conversation
@nik132-eng is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions for pull request titles! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR @nik132-eng looks good 😊
I just added the types to the cycle check function as it was untyped before
What does this PR do?
This commit introduces a validation mechanism to remove cyclic logic from the survey data. This ensures that any cyclic dependencies are identified and removed before further processing, enhancing the reliability of the application.
Fixes #2408
How should this be tested?
In the logic section make a loop like q1 -> q2 -> q3 ( add logic that redirects to q1) -> q4. It creates a loop.
Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated