fix: nps and rating validation issue with mls #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
mattinannt
requested changes
Apr 9, 2024
There was a problem hiding this comment.
@Dhruwang thanks for the fix :-) I have a few change requests / questions.
Also is the Skip Button Label in CTA questions also affected of this?
| @@ -132,7 +132,7 @@ export default function QuestionsView({ | |||
|
|
|||
| // check if we are recalling from this question | |||
| updatedSurvey.questions.forEach((question) => { | |||
| if (question.headline[selectedLanguageCode].includes(`recall:${questionId}`)) { | |||
| if (question.headline[selectedLanguageCode]?.includes(`recall:${questionId}`)) { | |||
There was a problem hiding this comment.
Why is this needed? Typescript isn't complaining without it and also there are other occurences of
if (question.headline[selectedLanguageCode]...in the file
There was a problem hiding this comment.
There was a case where question.headline[selectedLanguageCode] becomes undefined and deletion is blocked, hence fixed the issue where it becomes undefined and reverted this change 😊
.../app/(app)/environments/[environmentId]/surveys/[surveyId]/edit/components/SurveyMenuBar.tsx
Outdated
Show resolved
Hide resolved
mattinannt
approved these changes
Apr 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes validation failing for nps and rating due to buttonLabel value
Also add functionality to make backButtonLabel undefined when it is the first question
Lavel validations for matrix question
How should this be tested?
Add NPS question
Enable translation (eng, german)
Make it optional, so you see an input field to configure next button value, write eng translation but leave german blank
Make it required (input field for next button disappears)
When trying to save it, we try to validate using default value, that if default value exist german translation should exist too
And hence throws validation error while saving (edited)
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated