fix: survey jumping to 3rd question with prefilling

[Dhruwang]

What does this PR do?

Eliminates activeQuestionid and onActiveQuestionChange and exposes a getter function getSetQuestionId which can be used on the outside to access internal setQuestionid
And some minor refactors

Fixes https://github.com/formbricks/internal/issues/51

How should this be tested?

Test survey with prefilling

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues
• First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)	Visit Preview		Apr 17, 2024 6:23pm
formbricks-com	⬜️ Ignored (Inspect)	Visit Preview		Apr 17, 2024 6:23pm

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[mattinannt]

@Dhruwang thanks for the PR :-) 💪 The use of questionId / getSetQuestionId looks good at first glance :-)

@gupta-piyush19 Can you please review the PR including testing the functionality for the survey editor and showing surveys with prefilling as well as startAt functionality? :-)

[gupta-piyush19]

@Dhruwang Thanks for the fix. 🙂
Code changes looks good, can you please check this one bug in the preview editor(in case of disabled thankyou card).

bug.mp4

[mattinannt]

@gupta-piyush19 Can you please check on the PR again and give your approval if you are now happy with the state of the PR? :-)

[gupta-piyush19]

Yes @mattinannt, looks good to me. It works as expected 🚀. Thanks, @Dhruwang, for the changes.