Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: website surveys #2423

Merged
merged 37 commits into from
Apr 23, 2024
Merged

feat: website surveys #2423

merged 37 commits into from
Apr 23, 2024

Conversation

pandeymangg
Copy link
Contributor

@pandeymangg pandeymangg commented Apr 10, 2024

What does this PR do?

Introduces a new survey type website, replaces the previous surveys typed as web to website and inApp using a data migration. Splits the js-package into two different exports in favour of js/website and js/in-app. Handles the UI changes and the package bundling changes and the database changes.

How should this be tested?

  • Create a new survey and look at the survey types, there should be a new website survey type.
  • Website surveys can be tracked in the demo app on the /website page.
  • The js package is split into js/website and js/in-app.

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 1:04pm
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 1:04pm

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pandeymangg Looks great! :-) 🚀
Can you please do the following before the merge:

  • Solve the merge conflicts and move the data migration to the new data-migrations folder
  • Rename in-app to app (as well as InApp->App, etc.). This way we have cleaner types and package names without hyphens :-)

@mattinannt mattinannt marked this pull request as ready for review April 22, 2024 06:46
@vercel vercel bot temporarily deployed to Preview – formbricks-cloud April 23, 2024 11:16 Inactive
@pandeymangg pandeymangg added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit 0e6cfbf Apr 23, 2024
12 checks passed
@pandeymangg pandeymangg deleted the feat/website-surveys branch April 23, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants